Skip to content

chore: exporters/prometheus/internal/x - Generate x package from x component template #7491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2025
Merged

chore: exporters/prometheus/internal/x - Generate x package from x component template #7491

merged 3 commits into from
Nov 14, 2025

Conversation

@petern48
Copy link
Contributor

@petern48 petern48 commented Oct 11, 2025 •
edited
Loading

Generates x using the template using go generate

closes #7383

@codecov
Copy link

codecov bot commented Oct 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.1%. Comparing base (cb5b1b6) to head (bec8f95).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7491     +/-   ##
=======================================
- Coverage   86.1%   86.1%   -0.1%     
=======================================
  Files        297     298      +1     
  Lines      21678   21687      +9     
=======================================
- Hits       18685   18681      -4     
- Misses      2620    2629      +9     
- Partials     373     377      +4
Files with missing lines Coverage Δ
exporters/prometheus/internal/x/features.go 100.0% <100.0%> (ø)
exporters/prometheus/internal/x/x.go 51.8% <ø> (-48.2%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petern48 petern48 marked this pull request as ready for review October 11, 2025 05:34
@petern48
Copy link
Contributor Author

petern48 commented Oct 11, 2025

Hi 👋, first time in this repo and first time using go generate (it's pretty cool!). Let me know if you have any feedback.

flc1125
flc1125 approved these changes Oct 11, 2025
View reviewed changes
@flc1125 flc1125 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 11, 2025
@petern48
Copy link
Contributor Author

petern48 commented Nov 14, 2025

gentle bump. Already has one approval

@dmathieu dmathieu merged commit 8c2fb6f into open-telemetry:main Nov 14, 2025
30 checks passed
@petern48 petern48 deleted the generate_prometheus_x branch November 14, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmathieu dmathieu dmathieu approved these changes

@flc1125 flc1125 flc1125 approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

exporters/prometheus/internal/x: generate x package from x component template

3 participants

@petern48 @dmathieu @flc1125